[
https://issues.apache.org/jira/browse/HBASE-20703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505311#comment-16505311
]
Hadoop QA commented on HBASE-20703:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 41 new + 14 unchanged - 12 fixed =
55 total (was 26) {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}
0m 4s{color} | {color:orange} The patch generated 19 new + 24 unchanged - 19
fixed = 43 total (was 43) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
32s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-20703 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926969/HBASE-20703.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux e25926faaafd 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / cfeb26d27a |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_171 |
| rubocop | v0.57.1 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/13143/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/13143/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/13143/testReport/ |
| Max. process+thread count | 2592 (vs. ulimit of 10000) |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13143/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> When quota feature is off shell should give a nice message
> ----------------------------------------------------------
>
> Key: HBASE-20703
> URL: https://issues.apache.org/jira/browse/HBASE-20703
> Project: HBase
> Issue Type: Improvement
> Components: shell, Usability
> Affects Versions: 2.0.0
> Reporter: Sean Busbey
> Assignee: Xu Cang
> Priority: Major
> Attachments: HBASE-20703.master.001.patch,
> HBASE-20703.master.003.patch
>
>
> When quota is off the shell gives a error that requires knowledge of our
> implementation details to understand:
> {code}
> 2.2.1 :001 > list_snapshot_sizes
> SNAPSHOT SIZE
>
>
> ERROR: Unknown table hbase:quota!
> For usage try 'help "list_snapshot_sizes"'
> Took 1.6285 seconds
>
>
> 2.2.1 :002 > list_quota_snapshots
> TABLE USAGE LIMIT IN_VIOLATION POLICY
> ERROR: Unknown table hbase:quota!
> For usage try 'help "list_quota_snapshots"'
> Took 0.0371 seconds
> {code}
> Or it just doesn't mention that quotas can't exist:
> {code}
> 2.2.1 :003 > list_quotas
> OWNER QUOTAS
>
>
> 0 row(s)
> Took 0.0475 seconds
>
>
> 2.2.1 :004 > list_quota_table_sizes
> TABLE SIZE
>
>
> 0 row(s)
> Took 0.1221 seconds
> {code}
> set quota gives a better pointer that the problem is the feature is off:
> {code}
> 2.2.1 :005 > set_quota USER => 'busbey', GLOBAL_BYPASS => true
> ERROR: org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.UnsupportedOperationException: quota support disabled
> at
> org.apache.hadoop.hbase.quotas.MasterQuotaManager.checkQuotaSupport(MasterQuotaManager.java:442)
> at
> org.apache.hadoop.hbase.quotas.MasterQuotaManager.setQuota(MasterQuotaManager.java:124)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.setQuota(MasterRpcServices.java:1555)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> Caused by: java.lang.UnsupportedOperationException: quota support disabled
> ... 8 more
> For usage try 'help "set_quota"'
> {code}
> Instead we should give a nice message, like you get if visibility labels is
> off:
> {code}
> 2.2.1 :06 > list_labels
> ERROR: DISABLED: Visibility labels feature is not available
> For usage try 'help "list_labels"'
> Took 0.0426 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
