[
https://issues.apache.org/jira/browse/HBASE-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505391#comment-16505391
]
Ted Yu commented on HBASE-20672:
--------------------------------
{code}
+ .addGauge(Interns.info(READ_REQUEST_RATE_PER_SECOND,
READ_REQUEST_RATE_DESC),
+ rsWrap.getReadRequestsRatePerSecond())
+ .addGauge(Interns.info(WRITE_REQUEST_RATE_PER_SECOND,
WRITE_REQUEST_RATE_DESC),
+ rsWrap.getWriteRequestsRatePerSecond());
{code}
Indentation for both metrics are off. Please align with existing code.
{code}
+ writeRequestsRatePerSecond = readRequestsRatePerMilliSecond/ 1000.0;
{code}
I think there is typo in the above assignment. Correspondingly, the computation
for writeRequestsRatePerMilliSecond should be added.
> Create new HBase metrics ReadRequestRate and WriteRequestRate that reset at
> every monitoring interval
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-20672
> URL: https://issues.apache.org/jira/browse/HBASE-20672
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Ankit Jain
> Assignee: Ankit Jain
> Priority: Minor
> Attachments: HBASE-20672.branch-1.001.patch,
> HBASE-20672.master.001.patch
>
>
> Hbase currently provides counter read/write requests (ReadRequestCount,
> WriteRequestCount). That said it is not easy to use counter that reset only
> after a restart of the service, we would like to expose 2 new metrics in
> HBase to provide ReadRequestRate and WriteRequestRate at region server level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
