[ https://issues.apache.org/jira/browse/HBASE-20695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505676#comment-16505676 ]
Guanghao Zhang commented on HBASE-20695: ---------------------------------------- {code:java} if (!source.getSourceMetrics().getSingleSourceSourceByTable() .containsKey(tableName.getNameAsString())) { source.getSourceMetrics().getSingleSourceSourceByTable() .put(tableName.getNameAsString(), CompatibilitySingletonFactory.getInstance(MetricsReplicationSourceFactory.class) .getSource(tableName.getNameAsString())); } {code} Do we have concurrent problem here? And maybe better put this logic in MetricSource and use computeIfAbsent instead. > Implement table level RegionServer replication metrics > ------------------------------------------------------- > > Key: HBASE-20695 > URL: https://issues.apache.org/jira/browse/HBASE-20695 > Project: HBase > Issue Type: Improvement > Components: metrics > Reporter: Xu Cang > Assignee: Xu Cang > Priority: Minor > Attachments: HBASE-20695.master.001.patch, > HBASE-20695.master.002.patch > > > Region server metrics now are mainly global metrics. It would be nice to have > table level metrics such as table level source.AgeOfLastShippedOp to indicate > operators which table's replication is lagging behind. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)