[ 
https://issues.apache.org/jira/browse/HBASE-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508604#comment-16508604
 ] 

Ankit Jain edited comment on HBASE-20672 at 6/11/18 9:51 PM:
-------------------------------------------------------------

Hey [~stack],

Thank you for your comments.

The intention behind these new metrics is to get a more real time understanding 
about the amount of read and write operations done by region server.

The current metrics ReadRequestCount and WriteRequestCount are essentially 
values incremented from the start of the service and hence it makes it 
difficult to analyze the current 

operation load on the region server.

Regarding your concern about extra overhead involved, for this patch we have 
not added any extra counters and are reusing the already existing ones.  

For populating the values for the rates, we are performing basic arithmetic 
operations using the values returned by preexisting counters.

Currently, metric calculation happens after every 5000 ms at region server 
level (DEFAULT_REGIONSERVER_METRICS_PERIOD = 5000. So that is what is currently 
being considered as monitoring interval.

So I guess it is just the monitoring system thing and is not specifically 
related to Hbase. 

I hope my comments answers your questions.

Do let me know if any other concerns.


was (Author: jain.ankit):
Hey [~stack],

Thank you for your comments.

The intention behind these new metrics is to get a more real time understanding 
about the amount of read and write operations done by region server.

The current metrics ReadRequestCount and WriteRequestCount are essentially 
values incremented from the start of the service and hence it makes it 
difficult to analyze the current 

operation load on the region server.

Regarding your concern about extra overhead involved, for this patch we have 
not added any extra counters and are reusing the already existing ones.  

For populating the values for the rates, we are performing basic arithmetic 
operations using the values returned by preexisting counters.

Currently, metric calculation happens after every 5000 ms at region server 
level (DEFAULT_REGIONSERVER_METRICS_PERIOD = 5000;). So that is what is 
currently being considered as monitoring interval.

So I guess it is just the monitoring system thing and is not specifically 
related to Hbase. 

I hope my comments answers your questions.

Do let me know if any other concerns.

> Create new HBase metrics ReadRequestRate and WriteRequestRate that reset at 
> every monitoring interval
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20672
>                 URL: https://issues.apache.org/jira/browse/HBASE-20672
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Ankit Jain
>            Assignee: Ankit Jain
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HBASE-20672.branch-1.001.patch, 
> HBASE-20672.master.001.patch, HBASE-20672.master.002.patch, 
> HBASE-20672.master.003.patch, hits1vs2.4.40.400.png
>
>
> Hbase currently provides counter read/write requests (ReadRequestCount, 
> WriteRequestCount). That said it is not easy to use counter that reset only 
> after a restart of the service, we would like to expose 2 new metrics in 
> HBase to provide ReadRequestRate and WriteRequestRate at region server level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to