[
https://issues.apache.org/jira/browse/HBASE-20727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511295#comment-16511295
]
Ted Yu commented on HBASE-20727:
--------------------------------
{code}
+ } catch (IOException e) {
+ LOG.warn("Failed to load last flushed sequence id of regions"
+ + " from file system", e);
{code}
Since operator cannot take any action seeing the above, I think DEBUG log would
be better.
{code}
+ // trigger a persist of flushedSeqId
+ if (flushedSeqIdFlusher != null) {
+ flushedSeqIdFlusher.triggerNow();
{code}
The above is added to expireServer(). If there're multiple servers expiring
around the same time, does the flush need to happen for every server ?
{code}
+ * start chore in ServerManager
+ */
+ public void startChore() {
{code}
Does the chore need to start when the enable flag is false ?
removeDeletedRegionFromLoadedFlushedSequenceIds iterates
flushedSequenceIdByRegion twice. It seems using iterator one traversal should
suffice.
> Persist FlushedSequenceId to speed up WAL split after cluster restart
> ---------------------------------------------------------------------
>
> Key: HBASE-20727
> URL: https://issues.apache.org/jira/browse/HBASE-20727
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 2.0.0
> Reporter: Allan Yang
> Assignee: Allan Yang
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20727.patch
>
>
> We use flushedSequenceIdByRegion and storeFlushedSequenceIdsByRegion in
> ServerManager to record the latest flushed seqids of regions and stores. So
> during log split, we can use seqids stored in those maps to filter out the
> edits which do not need to be replayed. But, those maps are not persisted.
> After cluster restart or master restart, info of flushed seqids are all lost.
> Here I offer a way to persist those info to HDFS, even if master restart, we
> can still use those info to filter WAL edits and then to speed up replay.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
