[ https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512983#comment-16512983 ]
Hudson commented on HBASE-20625: -------------------------------- Results for branch master [build #365 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/365/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/365//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/365//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/365//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > refactor some WALCellCodec related code > --------------------------------------- > > Key: HBASE-20625 > URL: https://issues.apache.org/jira/browse/HBASE-20625 > Project: HBase > Issue Type: Improvement > Components: wal > Affects Versions: 2.0.0 > Reporter: Jingyun Tian > Assignee: Jingyun Tian > Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20625.branch-2.001.patch, > HBASE-20625.master.001.patch, HBASE-20625.master.002.patch, > HBASE-20625.master.002.patch, HBASE-20625.master.003.patch, > HBASE-20625.master.004.patch, HBASE-20625.master.005.patch, > HBASE-20625.master.006.patch, HBASE-20625.master.007.patch, > HBASE-20625.master.008.patch > > > Currently I'm working on export HLog to another FileSystem, then I found the > code of WALCellCodec and its related classes is not that clean. And there > are several TODOs. Thus I tried to refactor the code based one these TODOs. > e.g. > {code} > // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if > it was here. > // Dictionary could be gotten by enum; initially, based on enum, > context would create > // an array of dictionaries. > static class BaosAndCompressor extends ByteArrayOutputStream implements > ByteStringCompressor { > public ByteString toByteString() { > // We need this copy to create the ByteString as the byte[] 'buf' is > not immutable. We reuse > // them. > return ByteString.copyFrom(this.buf, 0, this.count); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)