[
https://issues.apache.org/jira/browse/HBASE-20332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515471#comment-16515471
]
Sean Busbey commented on HBASE-20332:
-------------------------------------
-v7
- comment out the checkstyle based checking for HTrace v3
To make use of the message attribute on the suppression we'll need to update to
[version 1.2 of the suppression
DTD|https://checkstyle.org/dtds/suppressions_1_2.dtd] and move to a version of
checkstyle that recognizes it, which is checkstyle 8.6+. We can't do that yet
because [checkstyle #5279|https://github.com/checkstyle/checkstyle/issues/5279]
is still open.
I've commented out the changes to use checkstyle to watch for htrave v3 and
left them as TODO for when we can upgrade our checkstyle version. I think we're
better off waiting for that then relying on the precommit 'hbaseanti' check
that points out lines in the patch file. I am fine with doing both (the
comments for later and the precommit patch grep) if anyone prefers.
bq. ugh. checkstyle in hte precommit run broke with a complaint that the
suppression isn't valid. but it works locally? trying to figure out the
difference.
This was a cached hbase-checkstyle jar in my environment. The reason the
checkstyle complaints weren't present was because the cached version had
neither the new rule for {{org.apache.htrace}} nor the suppression that is
causing the error in precommit.
> shaded mapreduce module shouldn't include hadoop
> ------------------------------------------------
>
> Key: HBASE-20332
> URL: https://issues.apache.org/jira/browse/HBASE-20332
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce, shading
> Affects Versions: 2.0.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20332.0.patch, HBASE-20332.1.WIP.patch,
> HBASE-20332.2.WIP.patch, HBASE-20332.3.patch, HBASE-20332.4.patch,
> HBASE-20332.5.patch, HBASE-20332.6.patch, HBASE-20332.7.patch
>
>
> AFAICT, we should just entirely skip including hadoop in our shaded mapreduce
> module
> 1) Folks expect to run yarn / mr apps via {{hadoop jar}} / {{yarn jar}}
> 2) those commands include all the needed Hadoop jars in your classpath by
> default (both client side and in the containers)
> 3) If you try to use "user classpath first" for your job as a workaround
> (e.g. for some library your application needs that hadoop provides) then our
> inclusion of *some but not all* hadoop classes then causes everything to fall
> over because of mixing rewritten and non-rewritten hadoop classes
> 4) if you don't use "user classpath first" then all of our
> non-relocated-but-still-shaded hadoop classes are ignored anyways so we're
> just wasting space
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
