[
https://issues.apache.org/jira/browse/HBASE-20781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522907#comment-16522907
]
stack commented on HBASE-20781:
-------------------------------
So, FSWALEntry should be good but perhaps you are worried about WALEdit
[~Apache9]. Yes, CPs can add edits for inclusion in a WALEdit and they *could*
be edits that have a Column Family outside of the current transaction Set.
Let me accommodate inside this hack by making it so we auto-accumulate families
even if the custom add done for CPs.
Related, there is HBASE-19134, Make WALKey an Interface; expose Read-Only
version to CPs, which is in 2.0.0. WALKey is read-only. CPs cannot #add
directly to WALEdit which means we should be good with our internal handling of
adds to WALEdit.
> Save recalculating families in a WALEdit batch of Cells
> -------------------------------------------------------
>
> Key: HBASE-20781
> URL: https://issues.apache.org/jira/browse/HBASE-20781
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
> Reporter: stack
> Assignee: stack
> Priority: Major
> Attachments: 2.0621.2.12782.cpu.svg, 2.0621.256k.51351.cpu.svg,
> 2.0623.families.121250.cpu.svg, HBASE-20781.branch-2.0.001.patch,
> HBASE-20781.master.001.patch
>
>
> Doing a doMiniBatchMutate, we calculate the set of families that the WALEdit
> Cells belong to up front but down after the RingBuffer when we make an
> FSWALEdit, we spin through all the Cells again to figure the set of families
> in a particularly painful way. Just pass the calculated family set in the
> WALEdit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
