[
https://issues.apache.org/jira/browse/HBASE-15320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525956#comment-16525956
]
Ted Yu commented on HBASE-15320:
--------------------------------
For
hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/HbaseKafkaProxy.java
, I think the prefix Hbase in the class name is not needed - the class is in
org.apache.hadoop.hbase.kafka package.
{code}
+ .filter((arg)->(arg.startsWith("-D")||arg.equalsIgnoreCase("start")))
{code}
Do we accept spelling(s) for starting region server other than "start" ?
{code}
+ List<String> addArgs = DEFAULT_PROPERTIES.keySet().stream()
{code}
You can name addArgs variable allArgs.
{code}
+ LOG.warn("znode "+idPath+" has unexpected value "
+ + " (did the peer name for the proxy change?) "
{code}
Include the current value for the znode in the log.
{code}
+ * @param createIfMissing if the peer doesn't exist, create it and peer to
it.
+ */
{code}
Please add javadoc for enablePeer parameter.
Will leave more comments once the patch is uploaded to review board.
> HBase connector for Kafka Connect
> ---------------------------------
>
> Key: HBASE-15320
> URL: https://issues.apache.org/jira/browse/HBASE-15320
> Project: HBase
> Issue Type: New Feature
> Components: Replication
> Reporter: Andrew Purtell
> Assignee: Mike Wingert
> Priority: Major
> Labels: beginner
> Fix For: 3.0.0
>
> Attachments: HBASE-15320.master.1.patch, HBASE-15320.master.10.patch,
> HBASE-15320.master.11.patch, HBASE-15320.master.12.patch,
> HBASE-15320.master.2.patch, HBASE-15320.master.3.patch,
> HBASE-15320.master.4.patch, HBASE-15320.master.5.patch,
> HBASE-15320.master.6.patch, HBASE-15320.master.7.patch,
> HBASE-15320.master.8.patch, HBASE-15320.master.8.patch,
> HBASE-15320.master.9.patch, HBASE-15320.pdf, HBASE-15320.pdf
>
>
> Implement an HBase connector with source and sink tasks for the Connect
> framework (http://docs.confluent.io/2.0.0/connect/index.html) available in
> Kafka 0.9 and later.
> See also:
> http://www.confluent.io/blog/announcing-kafka-connect-building-large-scale-low-latency-data-pipelines
> An HBase source
> (http://docs.confluent.io/2.0.0/connect/devguide.html#task-example-source-task)
> could be implemented as a replication endpoint or WALObserver, publishing
> cluster wide change streams from the WAL to one or more topics, with
> configurable mapping and partitioning of table changes to topics.
> An HBase sink task
> (http://docs.confluent.io/2.0.0/connect/devguide.html#sink-tasks) would
> persist, with optional transformation (JSON? Avro?, map fields to native
> schema?), Kafka SinkRecords into HBase tables.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
