[
https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526401#comment-16526401
]
Chia-Ping Tsai commented on HBASE-20575:
----------------------------------------
{code:java}
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:202:17: C:
Style/StringLiterals: Prefer single-quoted strings when you don't need string
interpolation or special symbols.
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:205:7: C:
Layout/AlignParameters: Align the parameters of a method call if they span more
than one line.
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:205:25: C:
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3
digits with them.
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:207:81: C:
Metrics/LineLength: Line is too long. [87/80]
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:208:81: C:
Metrics/LineLength: Line is too long. [101/80]
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:213:81: C:
Metrics/LineLength: Line is too long. [118/80]
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:213:84: C:
Layout/SpaceAfterComma: Space missing after comma.
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:214:81: C:
Metrics/LineLength: Line is too long. [132/80]
/testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:214:98: C:
Layout/SpaceAfterComma: Space missing after comma.{code}
Seems some suggestions can be addressed. [~mingdaoy] Could you update the
patch? thanks.
> Fail to config COMPACTION_ENABLED by hbase shell
> ------------------------------------------------
>
> Key: HBASE-20575
> URL: https://issues.apache.org/jira/browse/HBASE-20575
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 1.3.2
> Reporter: Chia-Ping Tsai
> Assignee: Mingdao Yang
> Priority: Major
> Fix For: 1.2.7, 1.3.3
>
> Attachments: HBASE-20575-branch-1.2.patch,
> HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch,
> HBASE-20575-branch-1.2.v3.patch
>
>
> HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However,
> we made a mistaken to COMPACTION_ENABLED.
> {code:java}
> htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if
> arg[COMPACTION_ENABLED]{code}
> arg.delete[COMPACTION_ENABLED] should be changed to
> arg.delete(COMPACTION_ENABLED)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
