[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527069#comment-16527069 ]
Mike Drob commented on HBASE-20764: ----------------------------------- anybody able to do reviews here? > build broken when latest commit is gpg signed > --------------------------------------------- > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build > Affects Versions: 3.0.0 > Reporter: Mike Drob > Assignee: Mike Drob > Priority: Critical > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > <identifier> expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > <identifier> expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg: using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) <md...@apache.org>" > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)