[
https://issues.apache.org/jira/browse/HBASE-20808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529003#comment-16529003
]
Nihal Jain commented on HBASE-20808:
------------------------------------
{quote}For a logic clear code base, having a clear start
getChoreService().scheduleChore(ScheduledChore);, it is better to have a clear
end getChoreService().cancelChore(ScheduledChore);.
{quote}
Isn't it sometimes better to have a cleaner solution than an ideal solution?
Anyways, I have attached a new patch with the suggested change:
[^HBASE-20808.master.002.patch]
> Wrong shutdown order between Chores and ChoreService
> ----------------------------------------------------
>
> Key: HBASE-20808
> URL: https://issues.apache.org/jira/browse/HBASE-20808
> Project: HBase
> Issue Type: Bug
> Reporter: Reid Chan
> Assignee: Nihal Jain
> Priority: Minor
> Labels: beginner
> Attachments: HBASE-20808.master.001.patch,
> HBASE-20808.master.002.patch
>
>
> When stopping master, {{ChoreService}}, which serves all the chores, is
> stopped before canceling all running chores.
> It should cancel all running chores, then shutdown {{ChoreService}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
