[
https://issues.apache.org/jira/browse/HBASE-20837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tak Lon (Stephen) Wu updated HBASE-20837:
-----------------------------------------
Attachment: (was: proposed-import-orders.png)
> Sync between dev-support/hbase_eclipse_formatter.xml and hbase/checkstyle.xml
> -----------------------------------------------------------------------------
>
> Key: HBASE-20837
> URL: https://issues.apache.org/jira/browse/HBASE-20837
> Project: HBase
> Issue Type: Task
> Affects Versions: 3.0.0, 2.0.1, 1.4.5
> Reporter: Tak Lon (Stephen) Wu
> Priority: Major
> Attachments: image-2018-07-02-15-27-41-140.png
>
>
> While working on HBASE-20557 contribution, we figured out that the checkstyle
> build target (ImportOrder's `groups`
> [http://checkstyle.sourceforge.net/config_imports.html] ) was different from
> the development supported IDE formatter, we would provide a fix here to sync
> between dev-support/hbase_eclipse_formatter.xml and hbase/checkstyle.xml
> This might need to backport the changes of master to branch-1 and branch-2 as
> well.
> Before this change, this is what checkstyle is expecting for import order
>
> {code:java}
> import com.google.common.annotations.VisibleForTesting;
> import java.io.IOException;
> import java.util.ArrayList;
> import java.util.List;
> import java.util.Map;
> import org.apache.commons.logging.Log;
> import org.apache.commons.logging.LogFactory;
> import org.apache.hadoop.conf.Configuration;
> import org.apache.hadoop.hbase.classification.InterfaceAudience;
> import org.apache.hadoop.hbase.conf.ConfigurationObserver;{code}
>
> And the proposed import order with the respect to HBASE-19262 and HBASE-19552
> should be
> !image-2018-07-02-15-27-41-140.png!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
