[
https://issues.apache.org/jira/browse/HBASE-20808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534430#comment-16534430
]
Nihal Jain edited comment on HBASE-20808 at 7/6/18 5:09 AM:
------------------------------------------------------------
bq. In branch-1 v1, can these be put into {{stopServiceThread}} as well?
I don't think so. This method is also called by master, which might not have
some of these scheduled on it.
But surely we can put it a little ahead of {{stopServiceThread()}} call.
OR
We can do the following inside {{stopServiceThread()}}:
{code:java}
if (this instanceof HMaster) {
. . .
}
{code}
What do you say?
was (Author: nihaljain.cs):
bq. In branch-1 v1, can these be put into {{stopServiceThread}} as well?
I don't think so. This method is also called by master, which might not have
some of these scheduled on it.
But surely we can put it a little ahead of stopServiceThread() call
What do you say?
> Wrong shutdown order between Chores and ChoreService
> ----------------------------------------------------
>
> Key: HBASE-20808
> URL: https://issues.apache.org/jira/browse/HBASE-20808
> Project: HBase
> Issue Type: Bug
> Reporter: Reid Chan
> Assignee: Nihal Jain
> Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.4.6, 2.0.2
>
> Attachments: HBASE-20808.branch-1.001.patch,
> HBASE-20808.master.001.patch, HBASE-20808.master.002.patch,
> HBASE-20808.master.003.patch, HBASE-20808.master.004.patch
>
>
> When stopping master, {{ChoreService}}, which serves all the chores, is
> stopped before canceling all running chores.
> It should cancel all running chores, then shutdown {{ChoreService}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
