[
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534506#comment-16534506
]
Yu Li commented on HBASE-20838:
-------------------------------
bq. I presume there's a reason we can't move the setStoragePolicy stuff from
CommonFSUtils to FSUtils?
I'm afraid yes, the constructor of {{WALProcedureStore}} invokes
{{CommonFSUtils#setStoragePolicy}} but the class is located in hbase-procedure
module which has no dependency of hbase-server
bq. What if in precommit we add hbase-server to the set of "needs a test run"
modules if CommonFSUtils is in the list of modified files?
I think this is a good idea sir [~busbey]
> Move all setStorage related UT cases from TestFSUtils to TestCommonFSUtils
> --------------------------------------------------------------------------
>
> Key: HBASE-20838
> URL: https://issues.apache.org/jira/browse/HBASE-20838
> Project: HBase
> Issue Type: Test
> Reporter: Yu Li
> Assignee: Yu Li
> Priority: Major
>
> As per
> [discussed|https://issues.apache.org/jira/browse/HBASE-20691?focusedCommentId=16517662&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16517662]
> in HBASE-20691, since the setStoragePolicy code is in CommonFSUtils, the
> test should be in TestCommonFSUtils
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
