[
https://issues.apache.org/jira/browse/HBASE-20837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535276#comment-16535276
]
Tak Lon (Stephen) Wu edited comment on HBASE-20837 at 7/6/18 8:14 PM:
----------------------------------------------------------------------
Mainly, this change added importorder files to make eclipse user to have the
same `Organize Imports`, this also require updates on the [Eclipse
section|http://hbase.apache.org/book.html#eclipse] with a 165.1.2 Import Orders
of how to use the importorder file)
for IDEA user, I'd suggest to update the [IDEA section in Reference
Guide|http://hbase.apache.org/book.html#_intellij_idea] with the following
graph to guide them setup manually (this is the same import layout mentioned in
HBASE-19262). Unless you guys agree to add [^hbase-intellij-formatter.xml] to
the dev-support as well to automatically setup the import orders and code
format, then we have to support/maintain formatter for two IDEs which I don't
think it's ideal for this issue
!IDEA import layout.png!
was (Author: taklwu):
Mainly, this change added importorder files to make eclipse user to have the
same `Organize Imports`, this also require updates on the [Eclipse
section|http://hbase.apache.org/book.html#eclipse] with a 165.1.2 Import Orders
of how to use the importorder file)
for IDEA user, I'd suggest to update the [IDEA section in Reference
Guide|http://hbase.apache.org/book.html#_intellij_idea] with the following
graph to guide them setup manually (this is the same import layout mentioned in
HBASE-19262).
!IDEA import layout.png!
> Make IDE configuration for import order match that in our checkstyle module
> ---------------------------------------------------------------------------
>
> Key: HBASE-20837
> URL: https://issues.apache.org/jira/browse/HBASE-20837
> Project: HBase
> Issue Type: Improvement
> Components: community
> Affects Versions: 3.0.0, 2.0.1, 1.4.5
> Reporter: Tak Lon (Stephen) Wu
> Assignee: Tak Lon (Stephen) Wu
> Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0
>
> Attachments: HBASE-20837.branch-1.001.patch,
> HBASE-20837.branch-2.001.patch, HBASE-20837.master.001.patch, IDEA import
> layout.png, hbase-intellij-formatter.xml
>
>
> While working on HBASE-20557 contribution, we figured out that the checkstyle
> build target (ImportOrder's `groups`
> [http://checkstyle.sourceforge.net/config_imports.html] ) was different from
> the development supported IDE (e.g. IntelliJ and Eclipse) formatter, we would
> provide a fix here to sync between
> [dev-support/hbase_eclipse_formatter.xml|https://github.com/apache/hbase/blob/master/dev-support/hbase_eclipse_formatter.xml]
> and
> [hbase/checkstyle.xml|https://github.com/apache/hbase/blob/master/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml]
> This might need to backport the changes of master to branch-1 and branch-2 as
> well.
> Before this change, this is what checkstyle is expecting for import order
>
> {code:java}
> import com.google.common.annotations.VisibleForTesting;
> import java.io.IOException;
> import java.util.ArrayList;
> import java.util.List;
> import java.util.Map;
> import org.apache.commons.logging.Log;
> import org.apache.commons.logging.LogFactory;
> import org.apache.hadoop.conf.Configuration;
> import org.apache.hadoop.hbase.classification.InterfaceAudience;
> import org.apache.hadoop.hbase.conf.ConfigurationObserver;{code}
>
> And the proposed import order with the respect to HBASE-19262 and HBASE-19552
> should be
>
> !IDEA import layout.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
