[
https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215861#comment-13215861
]
Devaraj Das commented on HBASE-5451:
------------------------------------
Thanks Stack, for the quick but detailed review...
bq. if (!head.hasUserInfo()) return;
bq. .. Then you'd save an indent of the whole body of the method.
Makes sense
bq. Seems like ticket should be renamed user (we seem to be creating a user
rather than a ticket?) here – I like the way you ask user to create passing the
header:
Makes sense
bq. Is ConnectionContext actually the headers? Should it be called
ConnectionHeader?
Ok
bq. What is this – HBaseCompleteRpcRequestProto? Its 'The complete RPC request
message'. Its the callid and the client request. Is it the complete request
because its missing the header? Should it just be called Request since its
inside a package that makes its provinence clear? I suppose request would be
odd because you then do getRequest on it... hmm.
The CompleteRPCRequest message is composed of the RPC callID and the
application RPC message (currently either a Writable or a PB). I wanted to
distinguish between the two, but let me look at renaming ..
bq. Why tunnelRequest. Whats that mean?
Currently, the RPC client only works with Writables. We will need to tunnel
Writable RPC messages until we have PB for all the app layer protocols. Kindly
have a look at the client side where the writable RPC message is serialized for
sending it to the server.
bq. Fatten doc on the proto file I'd say. Its going to be our spec.
Ok
bq. Can these proto classes drop the HBaseRPC prefix? Is the Proto suffix going
to be our convention denoting Proto classes going forward?
Will drop the prefix. But I guess the suffix should stay..
bq. Are we doing to repeat the hrpc exception handling carrying Strings for
exceptions from server to client?
Haven't done anything on this one yet. Let me see (this could be a separate
jira IMO).
> Switch RPC call envelope/headers to PBs
> ---------------------------------------
>
> Key: HBASE-5451
> URL: https://issues.apache.org/jira/browse/HBASE-5451
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Devaraj Das
> Attachments: rpc-proto.patch.1_2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
