[ 
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yu Li updated HBASE-20838:
--------------------------
    Hadoop Flags: Reviewed
     Description: 
-As per 
[discussed|https://issues.apache.org/jira/browse/HBASE-20691?focusedCommentId=16517662&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16517662]
 in HBASE-20691, since the setStoragePolicy code is in CommonFSUtils, the test 
should be in TestCommonFSUtils-
We don't want to introduce dependency on hadoop-hdfs to hbase-common so decided 
to leave the setStoragePolicy related tests in TestCommonFSUtils. Instead, we 
will change the personality script to include hbase-server in unit test if any 
change made against {{CommonFSUtils}}

  was:As per 
[discussed|https://issues.apache.org/jira/browse/HBASE-20691?focusedCommentId=16517662&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16517662]
 in HBASE-20691, since the setStoragePolicy code is in CommonFSUtils, the test 
should be in TestCommonFSUtils


Updated title and description.

Thanks [~busbey] for review, will commit this soon.

> Include hbase-server in precommit test if CommonFSUtils is changed
> ------------------------------------------------------------------
>
>                 Key: HBASE-20838
>                 URL: https://issues.apache.org/jira/browse/HBASE-20838
>             Project: HBase
>          Issue Type: Test
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Major
>         Attachments: HBASE-20838.patch, HBASE-20838.patch, 
> HBASE-20838.v2.patch
>
>
> -As per 
> [discussed|https://issues.apache.org/jira/browse/HBASE-20691?focusedCommentId=16517662&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16517662]
>  in HBASE-20691, since the setStoragePolicy code is in CommonFSUtils, the 
> test should be in TestCommonFSUtils-
> We don't want to introduce dependency on hadoop-hdfs to hbase-common so 
> decided to leave the setStoragePolicy related tests in TestCommonFSUtils. 
> Instead, we will change the personality script to include hbase-server in 
> unit test if any change made against {{CommonFSUtils}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to