[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542158#comment-16542158
]
Ted Yu commented on HBASE-20734:
--------------------------------
{code}
+ private FileSystem walFS;
{code}
Maybe put the above field next to {{HRegionFileSystem fs}}. Please also add
comment on the role for the above field.
{code}
+ public HRegionFileSystem getRegionWALFileSystem() throws IOException {
+ return new HRegionFileSystem(conf, getWalFileSystem(),
{code}
Can the HRegionFileSystem instance be buffered ?
{code}
+ public Path getWALRegionDir() throws IOException {
+ if (regionDir == null) {
{code}
Looks like naming the regionDir as {{walRegionDir}} would be better.
I don't seem to find the code where, if recovered edits dir is not found under
walFs, we should look under region dir.
> Colocate recovered edits directory with hbase.wal.dir
> -----------------------------------------------------
>
> Key: HBASE-20734
> URL: https://issues.apache.org/jira/browse/HBASE-20734
> Project: HBase
> Issue Type: Improvement
> Components: MTTR, Recovery, wal
> Reporter: Ted Yu
> Assignee: Zach York
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20734.branch-1.001.patch
>
>
> During investigation of HBASE-20723, I realized that we wouldn't get the best
> performance when hbase.wal.dir is configured to be on different (fast) media
> than hbase rootdir w.r.t. recovered edits since recovered edits directory is
> currently under rootdir.
> Such setup may not result in fast recovery when there is region server
> failover.
> This issue is to find proper (hopefully backward compatible) way in
> colocating recovered edits directory with hbase.wal.dir .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
