[
https://issues.apache.org/jira/browse/HBASE-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5442:
-------------------------------
Attachment: D1941.1.patch
mbautin requested code review of "[jira] [HBASE-5442] [89-fb] Use builder
pattern in StoreFile and HFile".
Reviewers: JIRA, khemani, Kannan
Cleaning up the factory method explosion in HFile writer and StoreFile. Now,
adding a new parameter to HFile/StoreFile writer initialization will not
require modifying factory method invocations all over the codebase.
HFile writer parametersin 89-fb that are not there in trunk are:
favoredNodes, bloom error rate (customized for the column family), bits per
checksum.
This patch also has a bit more cleanup than the trunk version
(https://reviews.facebook.net/D1893), getting rid of a couple more annoying
constructors. This will be contributed to trunk as a follow-up patch
TEST PLAN
Unit tests, deploy to dev cluster
REVISION DETAIL
https://reviews.facebook.net/D1941
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV1.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java
src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
src/test/java/org/apache/hadoop/hbase/regionserver/CreateRandomStoreFile.java
src/test/java/org/apache/hadoop/hbase/regionserver/HFileReadWriteTest.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4107/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Use builder pattern in StoreFile and HFile
> ------------------------------------------
>
> Key: HBASE-5442
> URL: https://issues.apache.org/jira/browse/HBASE-5442
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: D1893.1.patch, D1893.2.patch, D1941.1.patch,
> HFile-StoreFile-builder-2012-02-22_22_49_00.patch
>
>
> We have five ways to create an HFile writer, two ways to create a StoreFile
> writer, and the sets of parameters keep changing, creating a lot of
> confusion, especially when porting patches across branches. The same thing is
> happening to HColumnDescriptor. I think we should move to a "builder pattern"
> solution, e.g.
> {code:java}
> HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
> .setParameter1(value1)
> .setParameter2(value2)
> ...
> .build();
> {code}
> Each parameter setter being on its own line will make merges/cherry-pick work
> properly, we will not have to even mention default parameters again, and we
> can eliminate a dozen impossible-to-remember constructors.
> This particular JIRA addresses StoreFile and HFile refactoring. For
> HColumnDescriptor refactoring see HBASE-5357.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
