[
https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552324#comment-16552324
]
Tak Lon (Stephen) Wu edited comment on HBASE-20401 at 7/23/18 4:41 AM:
-----------------------------------------------------------------------
[~reidchan] Thanks, it seems that I will have to submit a backport for this
change in branch-1 although I attached as [^HBASE-20401.branch-1.002.patch]
(this time I generated it with {{git format-patch}}).
just saw your comment, let's see wait the QA result and see, thanks.
was (Author: taklwu):
[~reidchan] Thanks, it seems that I will have to submit a backport for this
change in branch-1 although I attached as [^HBASE-20401.branch-1.002.patch]
(this time I generated it with {{git format-patch}}), right?
> Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable
> ----------------------------------------------------------------------
>
> Key: HBASE-20401
> URL: https://issues.apache.org/jira/browse/HBASE-20401
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 3.0.0, 1.5.0, 2.0.0-beta-1, 1.4.4, 2.0.0
> Reporter: Tak Lon (Stephen) Wu
> Assignee: Tak Lon (Stephen) Wu
> Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.0.2, 2.2.0, 2.1.1
>
> Attachments: HBASE-20401.branch-1.001.patch,
> HBASE-20401.branch-1.002.patch, HBASE-20401.master.001.patch,
> HBASE-20401.master.002.patch, HBASE-20401.master.003.patch,
> HBASE-20401.master.004.patch, HBASE-20401.master.005.patch,
> HBASE-20401.master.006.patch, HBASE-20401.master.007.patch
>
>
> When backporting HBASE-18309 in HBASE-20352, the deleteFiles calls
> CleanerContext.java#getResult with a waitIfNotFinished timeout to wait for
> notification (notify) from the fs.delete file thread. there might be two
> situation need to tune the MAX_WAIT in CleanerContext or waitIfNotFinished
> when LogClearner call getResult.
> # fs.delete never complete (strange but possible), then we need to wait for
> a max of 60 seconds. here, 60 seconds might be too long
> # getResult is waiting in the period of 500 milliseconds, but the fs.delete
> has completed and setFromClear is set but yet notify(). one might want to
> tune this 500 milliseconds to 200 or less .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
