[
https://issues.apache.org/jira/browse/HBASE-20782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554426#comment-16554426
]
Jan Hentschel commented on HBASE-20782:
---------------------------------------
[~xucang] Thanks for the patch. Please have a look at the results from QA. The
following error seems to be the problem:
{code}
hbase/hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java:[94,15]
access(java.lang.String) in org.apache.hadoop.hbase.http.TestGlobalFilter
cannot override access(java.lang.String) in
org.apache.hadoop.hbase.http.HttpServerFunctionalTest
[ERROR] attempting to assign weaker access privileges; was public
{code}
Also, it seems that the patch introduces new Checkstyle warnings. Please fix
them.
> Fix duplication of TestServletFilter.access
> -------------------------------------------
>
> Key: HBASE-20782
> URL: https://issues.apache.org/jira/browse/HBASE-20782
> Project: HBase
> Issue Type: Improvement
> Reporter: Jan Hentschel
> Assignee: Xu Cang
> Priority: Minor
> Attachments: HBASE-20782.master.001.patch,
> HBASE-20782.master.001.patch, HBASE-20782.master.002.patch
>
>
> The {{access}} method in {{TestServletFilter}} is duplicated in
> {{TestPathFilter}}. The method should be moved into a common place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
