[jira] [Commented] (HBASE-20932) Effective MemStoreSize::hashCode()

[Mingliang Liu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-20932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556324#comment-16556324
 ] 

Mingliang Liu commented on HBASE-20932:
---------------------------------------

Thanks [~yuzhih...@gmail.com] for prompt review and commit!

> Effective MemStoreSize::hashCode() 
> -----------------------------------
>
>                 Key: HBASE-20932
>                 URL: https://issues.apache.org/jira/browse/HBASE-20932
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.2
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>            Priority: Major
>             Fix For: 2.2.0
>
>         Attachments: HBASE-20932.001.patch, HBASE-20932.002.patch
>
>
> After HBASE-20411 we have
> {code:java|title=MemStoreSize::hashCode()}
>   @Override
>   public int hashCode() {
>     long h = 31 * this.dataSize;
>     h = h + 31 * this.heapSize;
>     h = h + 31 * this.offHeapSize;
>     return (int) h;
>   }
>  {code}
> This is not effective {{hashCode()}} implementation. Instead we can use:
> {code:java|title=MemStoreSize::hashCode()}
>   @Override
>   public int hashCode() {
>     long h = this.dataSize;
>     h = h * 31 + this.heapSize;
>     h = h * 31 + this.offHeapSize;
>     return (int) h;
>   }
>  {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)