[
https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560452#comment-16560452
]
Ted Yu commented on HBASE-20950:
--------------------------------
Looks good overall.
{code}
+ CLUSTER.join();
}
- CLUSTER.join();
{code}
I am a bit curious - why moving the join call outside the if ?
> Helper method to configure secure DFS cluster for tests
> -------------------------------------------------------
>
> Key: HBASE-20950
> URL: https://issues.apache.org/jira/browse/HBASE-20950
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Affects Versions: 3.0.0
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
> Attachments: HBASE-20950.master.001.patch
>
>
> There is quite some boilerplate code for configuring a secure HDFS cluster
> for tests. The code is repeated in a number of test files within HBase code
> base. Convert the boilerplate code into a helper method to avoid duplication
> and lower maintenance effort.
> SecureTestCluster#setHdfsSecuredConfiguration
> TestSecureExport#setUpClusterKdc
> TestThriftSpnegoHttpServer#addSecurityConfigurations
> TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
