[ 
https://issues.apache.org/jira/browse/HBASE-20741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562633#comment-16562633
 ] 

huaxiang sun commented on HBASE-20741:
--------------------------------------

Thanks [~ram_krish] for the patch. I looked at the patch, looks good to me. One 
minor improvement, with the current one, let's say there are two repilcas, so 
for the daughter1 and daughter2's replica region, they are always assigned to 
the same rs. Can the second 
{code}
serverIdx = 0;
{code}
be removed? With a big cluster, all daughter regions will be assigned to 4 
rses. A little  better idea, given a random startServerIdx so all split will be 
assigned to random region servers.

serverIdx = Random.(0, severSize); serverIndex = (serverIndex + 1) % severSize.

> Split of a region with replicas creates all daughter regions and its replica 
> in same server
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20741
>                 URL: https://issues.apache.org/jira/browse/HBASE-20741
>             Project: HBase
>          Issue Type: Bug
>          Components: read replicas
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Major
>             Fix For: 2.2.0
>
>         Attachments: HBASE-20741.patch
>
>
> Generally it is better that the parent region when split creates the daughter 
> region in the same target server. 
> But for replicas also we do the same and all the replica regions are created 
> in the same target server. We should ideally be doing a round robin and only 
> the primary daughter region should be opened in the intended target server 
> (where the parent was previously opened).
> [~huaxiang] FYI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to