[
https://issues.apache.org/jira/browse/HBASE-20894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565691#comment-16565691
]
stack commented on HBASE-20894:
-------------------------------
bq. but don't think dropping the leading "is" is correct.
It is incorrect. "hasIs..." is 'wrong'. It is a double-verb, duplicated prefix
AND they disagree in tense.
I think you should change it, but its a 'nit'.
bq. Or maybe don't even need to log the filename in this case?
No harm logging filename; better than an IOE w/o specifics. If we skip the
file, thats fine.
Otherwise, +1.
> Move BucketCache from java serialization to protobuf
> ----------------------------------------------------
>
> Key: HBASE-20894
> URL: https://issues.apache.org/jira/browse/HBASE-20894
> Project: HBase
> Issue Type: Task
> Components: BucketCache
> Affects Versions: 2.0.0
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Major
> Fix For: 3.0.0
>
> Attachments:
> 0001-Write-the-CacheableDeserializerIdManager-index-into-.patch,
> HBASE-20894.WIP-2.patch, HBASE-20894.WIP.patch, HBASE-20894.master.001.patch,
> HBASE-20894.master.002.patch, HBASE-20894.master.003.patch,
> HBASE-20894.master.004.patch, HBASE-20894.master.005.patch
>
>
> We should use a better serialization format instead of Java Serialization for
> the BucketCache entry persistence.
> Suggested by Chris McCown, who does not appear to have a JIRA account.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
