[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566503#comment-16566503
]
Reid Chan edited comment on HBASE-20856 at 8/2/18 9:14 AM:
-----------------------------------------------------------
{quote}it is simpler to create, review, and push commits from a PR{quote}
No question, i didn't argue about this.
AFAIK, hbase has been years using jira-patch-rb way, and nowhere encourages
contributors to create PRs.
At least, we should have a dev@DISCUSS to determine whether to make {{PR}} as
an option for making contributions. If so, we should document well how
contributors and committers to do.
was (Author: reidchan):
{quote}it is simpler to create, review, and push commits from a PR{quote}
No question, i didn't argue about this.
AFAIK, hbase has been years using jira-patch-rb way, and nowhere encourages
contributors to create PRs.
At least, we should have a dev@DISCUSS to determine whether to make {{PR}} as
an option to make contributions. If so, we should document well how
contributors and committers to do.
> PITA having to set WAL provider in two places
> ---------------------------------------------
>
> Key: HBASE-20856
> URL: https://issues.apache.org/jira/browse/HBASE-20856
> Project: HBase
> Issue Type: Improvement
> Components: Operability, wal
> Affects Versions: 3.0.0
> Reporter: stack
> Assignee: Tak Lon (Stephen) Wu
> Priority: Minor
> Fix For: 3.0.0, 2.0.2, 2.2.0, 2.1.1
>
> Attachments: HBASE-20856.branch-2.001.patch,
> HBASE-20856.branch-2.002.patch, HBASE-20856.master.001.patch,
> HBASE-20856.master.002.patch, HBASE-20856.master.003.patch
>
>
> Courtesy of [~elserj], I learn that changing WAL we need to set two places...
> both hbase.wal.meta_provider and hbase.wal.provider. Operator should only
> have to set it in one place; hbase.wal.meta_provider should pick up general
> setting unless hbase.wal.meta_provider is explicitly set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
