[
https://issues.apache.org/jira/browse/HBASE-20940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567371#comment-16567371
]
Andrew Purtell commented on HBASE-20940:
----------------------------------------
Mostly LGTM.
Spelling error, referenes -> references:
{code}
+ LOG.error("Error trying to determine if store has referenes, " +
"assuming references exists",
+ ioe);
{code}
There are a number of reported checkstyle violations in
TestEndToEndSplitTransaction.java. Please fix them as you are touching this
file now.
Style nit, removeCompactedfiles -> removeCompactedFiles
{code}
+ public static void removeCompactedfiles(Connection conn, long timeout,
RegionInfo hri)
{code}
The precommit also showed a failure in TestHRegion but there were some
environmental problems apparent as well. Let me run the tests locally. I will
report back if I can reproduce it.
Once the minor issues are fixed looks good for commit from me
> HStore.cansplit should not allow split to happen if it has references
> ---------------------------------------------------------------------
>
> Key: HBASE-20940
> URL: https://issues.apache.org/jira/browse/HBASE-20940
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.3.2
> Reporter: Vishal Khandelwal
> Assignee: Vishal Khandelwal
> Priority: Major
> Fix For: 1.3.2
>
> Attachments: HBASE-20940.branch-1.3.v1.patch,
> HBASE-20940.branch-1.3.v2.patch, HBASE-20940.branch-1.v1.patch,
> HBASE-20940.v1.patch
>
>
> When split happens and immediately another split happens, it may result into
> a split of a region who still has references to its parent. More details
> about scenario can be found here HBASE-20933
> HStore.hasReferences should check from fs.storefile rather than in memory
> objects.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
