[
https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219347#comment-13219347
]
Hadoop QA commented on HBASE-5491:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516576/HBASE-5491.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -131 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 155 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationPeer
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1062//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1062//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1062//console
This message is automatically generated.
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf =
> HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated
> Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once
> HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code
> (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
