[ 
https://issues.apache.org/jira/browse/HBASE-20871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569187#comment-16569187
 ] 

stack edited comment on HBASE-20871 at 8/4/18 1:55 PM:
-------------------------------------------------------

I pushed this and an addendum that was up on branch-2.1 which had been pushed 
as "HBASE-20847 Addendum use addFront instead of addBack to add sub procedure". 
The addendum fixed the failing test. Addendum is below:

{code}
commit 17422910123e83a042a7cb67f58b5d9171d4034f (HEAD -> 2.0, origin/branch-2.0)
Author: zhangduo <[email protected]>
Date:   Wed Jul 11 20:28:35 2018 +0800

    HBASE-20847 Addendum use addFront instead of addBack to add sub procedure

diff --git 
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureScheduler.java
 
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureScheduler.java
index aee88d29e6..64971fd09d 100644
--- 
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureScheduler.java
+++ 
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureScheduler.java
@@ -1083,7 +1083,7 @@ public class TestMasterProcedureScheduler {

     // The queue for this table should be added back to run queue as the 
parent has the xlock, so we
     // can poll it out.
-    queue.addBack(proc);
+    queue.addFront(proc);
     assertSame(proc, queue.poll());
     // the parent has xlock on the table, and it is OK for us to acquire 
shared lock on the table,
     // this is what this test wants to confirm
{code}


was (Author: stack):
I pushed this and "HBASE-20847 Addendum use addFront instead of addBack to add 
sub procedure" at the same time. HBASE-20847 fixes the above test failure.

> Backport HBASE-20847 to branch-2.0: "The parent procedure of 
> RegionTransitionProcedure may not have the table lock"
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20871
>                 URL: https://issues.apache.org/jira/browse/HBASE-20871
>             Project: HBase
>          Issue Type: Bug
>          Components: amv2
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.2
>
>         Attachments: 
> 0001-HBASE-20847-The-parent-procedure-of-RegionTransition.branch-2.0.patch
>
>
> Evaluate HBASE-20847 for backport before we cut 2.0.2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to