[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570122#comment-16570122
]
Kuan-Po Tseng commented on HBASE-18201:
---------------------------------------
[~reidchan] Thanks for your review.
{quote} Is {{meta.getDataBlockEncoding()}} equals {{this.encoding}} (it looks
so to me). If so, {{this.encoding = encoding}} can be removed IMO.
{quote}
Yes. meta.getDataBlockEncoding == encodingCtx.getDataBlockEncoding() ==
encoding.
But
{code:java}
meta.getDataBlockEncoding().equals(DataBlockEncoding.ROW_INDEX_V1){code}
is needed.
We can change the code to
{code:java}
encoding.equals(DataBlockEncoding.ROW_INDEX_V1)
{code}
It seems more clear.
> add UT and docs for DataBlockEncodingTool
> -----------------------------------------
>
> Key: HBASE-18201
> URL: https://issues.apache.org/jira/browse/HBASE-18201
> Project: HBase
> Issue Type: Sub-task
> Components: tooling
> Reporter: Chia-Ping Tsai
> Assignee: Kuan-Po Tseng
> Priority: Minor
> Labels: beginner
> Attachments: HBASE-18201.master.001.patch,
> HBASE-18201.master.002.patch, HBASE-18201.master.002.patch,
> HBASE-18201.master.003.patch, HBASE-18201.master.004.patch,
> HBASE-18201.master.005.patch, HBASE-18201.master.005.patch,
> HBASE-18201.master.005.patch
>
>
> There is no example, documents, or tests for DataBlockEncodingTool. We should
> have it friendly if any use case exists. Otherwise, we should just get rid of
> it because DataBlockEncodingTool presumes that the implementation of cell
> returned from DataBlockEncoder is KeyValue. The presume may obstruct the
> cleanup of KeyValue references in the code base of read/write path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
