[
https://issues.apache.org/jira/browse/HBASE-20813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570422#comment-16570422
]
Josh Elser commented on HBASE-20813:
------------------------------------
{quote}I thought this suggestion meant, to keep MasterSpaceQuotaObserver for
backwards-compat issues?
{quote}
Well, we can keep the old one around, but we definitely shouldn't be
duplicating code as this patch does.
Anyways, looking at it again, we don't have users set this manually, instead
HBase configures it automatically (unless the users tells us not to). As such,
it's probably not a big deal to rename it instead of keeping the old impl
around (there's no reason I can think of that someone would _only_ want to drop
the table for space quotas but not RPC quotas).
> Remove RPC quotas when the associated table/Namespace is dropped off
> --------------------------------------------------------------------
>
> Key: HBASE-20813
> URL: https://issues.apache.org/jira/browse/HBASE-20813
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sakthi
> Assignee: Sakthi
> Priority: Minor
> Attachments: hbase-20813.master.001.patch
>
>
> In short, the below scenario shouldn't be the case.
> {noformat}
> hbase(main):023:0> create 't2','cf1'
> Created table t2
> Took 0.7405 seconds
> => Hbase::Table - t2
> hbase(main):024:0>
> hbase(main):025:0*
> hbase(main):026:0* set_quota TYPE => THROTTLE, TABLE => 't2', LIMIT =>
> '10M/sec'
> Took 0.0082 seconds
> hbase(main):027:0> list_quotas
> OWNER QUOTAS
> TABLE => t2 TYPE => THROTTLE, THROTTLE_TYPE => REQUEST_SIZE, LIMIT =>
> 10M/sec, SCOPE => MACHINE
> 1 row(s)
> Took 0.0291 seconds
> hbase(main):028:0> scan 'hbase:quota'
> ROW COLUMN+CELL
> t.t2 column=q:s, timestamp=1530165010888,
> value=PBUF\x12\x0B\x12\x09\x08\x04\x10\x80\x80\x80\x05 \x02
> 1 row(s)
> Took 0.0037 seconds
> hbase(main):029:0> disable 't2'
> Took 0.4328 seconds
> hbase(main):030:0> drop 't2'
> Took 0.2285 seconds
> hbase(main):031:0> list_quotas
> OWNER QUOTAS
> TABLE => t2 TYPE => THROTTLE, THROTTLE_TYPE => REQUEST_SIZE, LIMIT =>
> 10M/sec, SCOPE => MACHINE
> 1 row(s)
> Took 0.0230 seconds
> hbase(main):032:0> scan 'hbase:quota'
> ROW COLUMN+CELL
> t.t2 column=q:s, timestamp=1530165010888,
> value=PBUF\x12\x0B\x12\x09\x08\x04\x10\x80\x80\x80\x05 \x02
> 1 row(s)
> Took 0.0038 seconds
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
