[ 
https://issues.apache.org/jira/browse/HBASE-20965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571415#comment-16571415
 ] 

Reid Chan commented on HBASE-20965:
-----------------------------------

bq. REGION_SERVER_REPORT_HANDLER_COUNT = 
"hbase.regionserver.report.handler.count";
Move this parameter into {{MasterFifoRpcScheduler}} instead of {{HConstants}}, 
besides, please use 'hbase.master.**\**.**\**.**\**.', apparently it is master 
parameter, current naming is misleading, 'hbase.master.server.report.handler' 
for your reference. 
Please well java-doc to introduce what REPORT_HANDLER_COUNT for and what will 
happen if unset or set, which parameter it needs to cooperate with, when user 
chooses to use {{MasterFifoRpcScheduler}}


Mark {{MasterFifoRpcScheduler}} Evolving.
{quote}Special rpc scheduler only used for master.{quote}
Java docs about {{MasterFifoRpcScheduler}} is too simple to let people know why 
it is special...



{code}private static final Logger LOG = 
LoggerFactory.getLogger(MasterFifoRpcScheduler.class);{code}
Remove this unused LOG and related package, or LOG where necessary by your good 
judge.



> Separate region server report requests to new handlers
> ------------------------------------------------------
>
>                 Key: HBASE-20965
>                 URL: https://issues.apache.org/jira/browse/HBASE-20965
>             Project: HBase
>          Issue Type: Improvement
>          Components: Performance
>            Reporter: Yi Mei
>            Assignee: Yi Mei
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-20965.master.001.patch, 
> HBASE-20965.master.002.patch, HBASE-20965.master.003.patch, 
> HBASE-20965.master.004.patch, HBASE-20965.master.005.patch, 
> HBASE-20965.master.006.patch, HBASE-20965.master.007.patch, 
> HBASE-20965.master.008.patch
>
>
> In master rpc scheduler, all rpc requests are executed in a thread pool. This 
> task separates rs report requests to new handlers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to