[ 
https://issues.apache.org/jira/browse/HBASE-21027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573753#comment-16573753
 ] 

Sean Busbey commented on HBASE-21027:
-------------------------------------

{code}
68          // No synchronization here because weakly consistent view should be 
good enough
69          return registeredDeserializers.entrySet().stream()
70              .collect(Collectors.toMap(Map.Entry::getKey, v -> 
v.getClass().getName()));
{code}

weakly consistent is good enough because we only iterate once and we don't make 
any changes to  what a given key points at after inserting it? is that right?

> Inconsistent synchronization in CacheableDeserializerIdManager 
> ---------------------------------------------------------------
>
>                 Key: HBASE-21027
>                 URL: https://issues.apache.org/jira/browse/HBASE-21027
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 3.0.0
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HBASE-21027.master.001.patch
>
>
> There is some inconsistent synchronization going on in CDIM, we should switch 
> it to using ConcurrentHashMap and simplify our code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to