[
https://issues.apache.org/jira/browse/HBASE-21033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575420#comment-16575420
]
Lars Hofhansl commented on HBASE-21033:
---------------------------------------
Here's a sample patch for DISCUSSION.
It looks big, but it basically just renames 3 files and adds a simple subclass
that implements InternalScanner.
Note that this punts on dealing with ReversedKeyValueHeap. Technically we
should have two of those as well, but that would mean duplication of code. Open
to more changes.
This has annoyed me for quite a while... If I'm the only one, I'm happy to
close this.
> Separate StoreHeap from StoreFileHeap
> -------------------------------------
>
> Key: HBASE-21033
> URL: https://issues.apache.org/jira/browse/HBASE-21033
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Priority: Minor
> Attachments: 21033-branch-1.txt
>
>
> Currently KeyValueHeap is used for both, heaps of StoreScanners at the Region
> level as well as heaps of StoreFileScanners (and a MemstoreScanner) at the
> Store level.
> This is various problems:
> # Some incorrect method usage can only be deduced at runtime via runtime
> exception.
> # In profiling sessions it's hard to distinguish the two.
> # It's just not clean :)
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
