[ https://issues.apache.org/jira/browse/HBASE-21040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Subrat Mishra updated HBASE-21040: ---------------------------------- Assignee: Subrat Mishra Attachment: HBASE-21040.master.001.patch Status: Patch Available (was: Open) I have attached the patch for master branch. [~yuzhih...@gmail.com], Can you please review the patch? > Replace call to printStackTrace() with proper logger call > --------------------------------------------------------- > > Key: HBASE-21040 > URL: https://issues.apache.org/jira/browse/HBASE-21040 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Subrat Mishra > Priority: Minor > Attachments: HBASE-21040.master.001.patch > > > Here is related code: > {code} > hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreDriver.java: > e.printStackTrace(); > hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java: > first.printStackTrace(); > hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java: > t.printStackTrace(); > hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java: > e.printStackTrace(); > hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java: > e.printStackTrace(); > hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java: > e.printStackTrace(); > hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java: > e.printStackTrace(); > hbase-examples/src/main/java/org/apache/hadoop/hbase/mapreduce/SampleUploader.java: > e.printStackTrace(); > hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java: > e.printStackTrace(); > hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/HttpDoAsClient.java: > e.printStackTrace(); > hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/HttpDoAsClient.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java: > ioe.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java: > ie.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CopyTable.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HashTable.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/SyncTable.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TsvImporterMapper.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TsvImporterTextMapper.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java: > e.printStackTrace(); > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java: > e.printStackTrace(); > hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALPrettyPrinter.java: > e.printStackTrace(); > hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java: > e.printStackTrace(); > hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java: > e.printStackTrace(); > hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java: > e.printStackTrace(); > hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java: > e.printStackTrace(); > hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java: > ex.printStackTrace(); > hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java: > e.printStackTrace(); > {code} > The correct way of logging stack trace is to use the Logger instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)