Josh Elser commented on HBASE-21062:

{quote}Sorry I missed this point previously. It is right to keep the original 
No worries! You and I, both :)
{quote}'us it' -> "use it"
Thanks, Ted. Will fix on commit along with checkstyle.

Unit test failure seems unrelated based on error, but will rerun locally.

Ping [~Apache9], [~stack], for your branches.

> WALFactory has misleading notion of "default"
> ---------------------------------------------
>                 Key: HBASE-21062
>                 URL: https://issues.apache.org/jira/browse/HBASE-21062
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: 3.0.0, 2.0.2, 2.2.0, 2.1.1
>         Attachments: HBASE-21062.001.branch-2.0.patch, 
> HBASE-21062.002.branch-2.0.patch
> In WALFactory, there is an enum {{Providers}} which has a list of supported 
> WALProvider implementations. In addition to list this, there is also a 
> {{defaultProvider}} (which the Configuration defaults to), that is meant to 
> be our "advertised" default WALProvider.
> However, the implementation of {{getProviderClass}} in WALFactory doesn't 
> actually adhere to the value of this enum, instead *always* returning 
> AsyncFSWal if it can be loaded.
> Having the default value in the enum but then overriding it in the 
> implementation of {{getProviderClass}} is silly and misleading.

This message was sent by Atlassian JIRA

Reply via email to