[
https://issues.apache.org/jira/browse/HBASE-21066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xu Cang updated HBASE-21066:
----------------------------
Description:
{code:java}
public boolean isTableState(TableName tableName, TableState.State... states) {
try {
TableState tableState = getTableState(tableName);
return tableState.isInStates(states);
} catch (IOException e) {
LOG.error("Unable to get table " + tableName + " state", e);
// XXX: is it safe to just return false here?
return false;
}
}
{code}
When cannot get table state, returning false is not always safe or correct.
was:
{{public boolean isTableState(TableName tableName, TableState.State... states)
{}}
{{try {}}
{{TableState tableState = getTableState(tableName);}}
{{return tableState.isInStates(states);}}
{{} catch (IOException e) {}}
{{LOG.error("Unable to get table " + tableName + " state", e);}}
{{// XXX: is it safe to just return false here?}}
{{return false;}}
{{}}}
{{}}}
When cannot get table state, returning false is not always safe or correct.
> Improve isTableState() method to ensure caller gets correct info
> ----------------------------------------------------------------
>
> Key: HBASE-21066
> URL: https://issues.apache.org/jira/browse/HBASE-21066
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Xu Cang
> Assignee: Xu Cang
> Priority: Minor
>
>
> {code:java}
> public boolean isTableState(TableName tableName, TableState.State... states) {
> try {
> TableState tableState = getTableState(tableName);
> return tableState.isInStates(states);
> } catch (IOException e) {
> LOG.error("Unable to get table " + tableName + " state", e);
> // XXX: is it safe to just return false here?
> return false;
> }
> }
>
> {code}
>
> When cannot get table state, returning false is not always safe or correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
