[
https://issues.apache.org/jira/browse/HBASE-21066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584294#comment-16584294
]
Xu Cang commented on HBASE-21066:
---------------------------------
That's correct. I added 1.0 and 2.0 to affected versions.
The reason I created this new Jira is to fix this method and review the impact
on all callers and modify related unit tests to accommodate this change. I plan
to finish this patch and then the HBASE-20690 will be resolved. I will make
sure all related branches are covered. Thanks, [~apurtell] Please let me know
if you think I need to adjust something else.
> Improve isTableState() method to ensure caller gets correct info
> ----------------------------------------------------------------
>
> Key: HBASE-21066
> URL: https://issues.apache.org/jira/browse/HBASE-21066
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 1.3.0, 2.0.0
> Reporter: Xu Cang
> Assignee: Xu Cang
> Priority: Minor
> Attachments: HBASE-21066.master.001.patch
>
>
>
> {code:java}
> public boolean isTableState(TableName tableName, TableState.State... states) {
> try {
> TableState tableState = getTableState(tableName);
> return tableState.isInStates(states);
> } catch (IOException e) {
> LOG.error("Unable to get table " + tableName + " state", e);
> // XXX: is it safe to just return false here?
> return false;
> }
> }
>
> {code}
>
> When cannot get table state, returning false is not always safe or correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
