[ 
https://issues.apache.org/jira/browse/HBASE-20881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585015#comment-16585015
 ] 

stack commented on HBASE-20881:
-------------------------------

I went through the patch again. This is a monster effort. The review is mostly 
praise for the improvement and cleanup now I understand what is going on (adds 
a note that need a RN that explains in short at least why this patch is needed 
-- bucketing all to do w/ the region entity inside of one procedure rather than 
distributed among a few procedures and a new fencing mechanism that rules out 
strange states... etc). There are some questions. You might want to cut another 
patch to address... see what you think. Fine if you put off to follow-ons.

I'm good w/ this going into Master. We need to figure how to do the 
rolling-upgrade before backport to branch-2.

Nice work [~Apache9].

> Introduce a region transition procedure to handle all the state transition 
> for a region
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-20881
>                 URL: https://issues.apache.org/jira/browse/HBASE-20881
>             Project: HBase
>          Issue Type: Sub-task
>          Components: amv2, proc-v2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-20881-v1.patch, HBASE-20881-v10.patch, 
> HBASE-20881-v11.patch, HBASE-20881-v12.patch, HBASE-20881-v13.patch, 
> HBASE-20881-v13.patch, HBASE-20881-v14.patch, HBASE-20881-v14.patch, 
> HBASE-20881-v2.patch, HBASE-20881-v3.patch, HBASE-20881-v4.patch, 
> HBASE-20881-v4.patch, HBASE-20881-v5.patch, HBASE-20881-v6.patch, 
> HBASE-20881-v7.patch, HBASE-20881-v7.patch, HBASE-20881-v8.patch, 
> HBASE-20881-v9.patch, HBASE-20881.patch
>
>
> Now have an AssignProcedure, an UnssignProcedure, and also a 
> MoveRegionProcedure which schedules an AssignProcedure and an 
> UnssignProcedure to move a region. This makes the logic a bit complicated, as 
> MRP is not a RIT, so when SCP can not interrupt it directly...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to