[ 
https://issues.apache.org/jira/browse/HBASE-21105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591963#comment-16591963
 ] 

Sean Busbey commented on HBASE-21105:
-------------------------------------

bq.  Can we fix this as an addendum to HBASE-20940 ?

that'd be fine by me.

bq. I looked it result and somehow "TestHBaseFsck" did not run in results at 
all. I had attached results ([^result_HBASE-20940.branch-1.v2.log)] also with " 
HBASE-20940" I remember same thing happened with another test class as well.

That other issue was HBASE-21076. the solution there was a refactoring that I 
think made sense even without HBASE-20940 existing.

{{TestHBaseFsck}} didn't run because in your run the {{TestSpnegoHttpServer}} 
test failed. Tests in the HBase project are divided into two groups. Things in 
the first group are meant to be fast validations of basic functionality and the 
second one are things that take more time / resources. If the first group has a 
failure then the second group doesn't run at all. {{TestSpnegoHttpServer}} is 
in the first group and {{TestHBaseFsck}} is in the second.

> TestHBaseFsck failing in branch-1, branch-1.4, branch-1.3 with NPE
> ------------------------------------------------------------------
>
>                 Key: HBASE-21105
>                 URL: https://issues.apache.org/jira/browse/HBASE-21105
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck, test
>    Affects Versions: 1.5.0, 1.3.3, 1.4.7
>            Reporter: Sean Busbey
>            Assignee: Vishal Khandelwal
>            Priority: Major
>         Attachments: HBASE-21105.branch-1.v1.patch
>
>
> TestHBaseFsck in the mentioned branches has two tests that rely on 
> TestEndToEndSplitTransaction for blocking in the same way TestTableResource 
> used to before HBASE-21076.
> Both tests appear to specifically be testing that something happens after a 
> split, so we'll need a solution that removes the cross-test dependency but 
> still allows for "wait until this split has finished"
> example failure from branch-1
> {code}
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hbase.util.TestHBaseFsck.testSplitDaughtersNotInMeta(TestHBaseFsck.java:1985)
> {code}
> {code}
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hbase.util.TestHBaseFsck.testValidLingeringSplitParent(TestHBaseFsck.java:1934)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to