[
https://issues.apache.org/jira/browse/HBASE-20942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591968#comment-16591968
]
Josh Elser commented on HBASE-20942:
------------------------------------
{code:java}
hbase.ipc.trace.param.size{code}
This configuration key needs some work. It's unnecessarily obtuse to me (I read
it and have no idea what it actually controls). Why not something like
{{hbase.ipc.trace.max.length}} or {{hbase.ipc.trace.log.max.length}}?
{code:java}
+ String truncatedFlag = (truncatedLength == stringifiedParam.length())
+ ? "" : "
<TRUNCATED>";{code}
Parens are unnecessary, please drop. Good catch though.
While I applaud you writing a test, I feel like it might be overkill for what
it's testing. What about lifting the truncation logic to its own method and
testing it directly without having to spin up an entire HBase instance?
> Improve RpcServer TRACE logging
> -------------------------------
>
> Key: HBASE-20942
> URL: https://issues.apache.org/jira/browse/HBASE-20942
> Project: HBase
> Issue Type: Task
> Reporter: Esteban Gutierrez
> Assignee: Krish Dey
> Priority: Major
> Attachments: HBASE-20942.002.patch, HBASE-20942.003.patch
>
>
> Two things:
> * We truncate RpcServer output to 1000 characters for trace logging. Would
> be better if that value was configurable.
> * There is the chance for an ArrayIndexOutOfBounds when truncating the TRACE
> log message.
> Esteban mentioned this to me earlier, so I'm crediting him as the reporter.
> cc: [~elserj]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
