[
https://issues.apache.org/jira/browse/HBASE-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220563#comment-13220563
]
Hadoop QA commented on HBASE-5489:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516762/HBASE-5489-4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -129 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 155 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1077//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1077//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1077//console
This message is automatically generated.
> Add HTable accessor to get regions for a key range
> --------------------------------------------------
>
> Key: HBASE-5489
> URL: https://issues.apache.org/jira/browse/HBASE-5489
> Project: HBase
> Issue Type: Improvement
> Components: client
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Minor
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5489-2.patch, HBASE-5489-3-0.92.1.patch,
> HBASE-5489-3.patch, HBASE-5489-4.patch
>
>
> It would be nice to have an accessor to find all regions that overlap with a
> particular range of keys. Right now, the only way to accomplish that is to
> call HTable.getStartEndKeys(), then follow that with calls to
> getRegionLocation() for the range of keys you are interested in. This
> algorithm has 2 drawbacks:
> * It returns more keys than is necessary most of the time. This is
> especially evident if there are a lot of regions comprising the table and the
> range of keys is small.
> * It always does a scan of .META. via MetaScannerVisitor for at least
> HTable.getStartEndKeys(), and perhaps for HRegionLocations that are not
> already cached by the client.
> An accessor that limited its scans to a specified range could avoid scanning
> .META. at all if the HRegionLocations being fetched were already cached by
> the client, thereby potentially making this operation faster in common cases.
> Here's a proposal for the accessor:
> /**
> * Get the corresponding regions for an arbitrary range of keys.
> * <p>
> * @param startRow Starting row in range, inclusive
> * @param endRow Ending row in range, inclusive
> * @return A list of HRegionLocations corresponding to the regions that
> * contain the specified range
> * @throws IOException if a remote or network exception occurs
> */
> public List<HRegionLocation> getRegionsInRange(final byte [] startKey,
> final byte [] endKey) throws IOException
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
