[
https://issues.apache.org/jira/browse/HBASE-21110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594263#comment-16594263
]
Andrew Purtell commented on HBASE-21110:
----------------------------------------
bq. We already hide most of our Unsafe access behind a facade, maybe there is
something we can do to set it up inline.
Yeah I should amend my comment because I was mixing concerns.
Wherever we use Unsafe, we'd pull out the surrounding code into a separate
Maven module, and then implement in another a VarHandle based alternative. This
is partly done now, we just don't have the relevant classes moved out to their
own module. Of the alternative implementations only one would be used over the
lifetime of a JVM process, so the JVM will see the calls through the interface
as monomorphic and they will be inlined.
> Issues with Unsafe and JDK 11
> -----------------------------
>
> Key: HBASE-21110
> URL: https://issues.apache.org/jira/browse/HBASE-21110
> Project: HBase
> Issue Type: Task
> Reporter: Mike Drob
> Priority: Major
> Fix For: 3.0.0
>
>
> Using Java 11 RC 1, I get the following warning, probably need to add the
> suggested flag to our scripts?
> {noformat}
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ java -version
> java version "11" 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ bin/start-hbase.sh
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ cat
> /Users/mdrob/IdeaProjects/hbase/bin/../logs/hbase-mdrob-master-mdrob-MBP.local.out
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> (file:/Users/mdrob/IdeaProjects/hbase/hbase-common/target/hbase-common-3.0.0-SNAPSHOT.jar)
> to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
