[
https://issues.apache.org/jira/browse/HBASE-21061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-21061:
--------------------------------
Status: Patch Available (was: In Progress)
since [builds.a.o and thus precommit is
down|https://status.apache.org/incidents/4zl6mkyrg8qt] I'm planning to wait to
upload the other branch-specific backports.
-branch-1 v0
- move the critical block so that instead of being the entire
{{readAndProcess}} method, it's just the section where we access the {{data}}
member
- create local variables for the member variables we access in the new
critical block that we don't synchronize consistently (since it appears that
they don't need to be)
- reference the local variables instead of the member variables
N.B. it's easier to review this patch if you apply it locally and then use
{{git diff -w}} to see the change.
tested by running findbugs locally (it still sees some other medium concern
unrelated to the one I'm fixing here on branch-1, branch-1.4, and branch-1.3)
and running the RPC related unit tests.
> fix synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap
> -------------------------------------------------------------------------------
>
> Key: HBASE-21061
> URL: https://issues.apache.org/jira/browse/HBASE-21061
> Project: HBase
> Issue Type: Sub-task
> Components: rpc
> Affects Versions: 1.4.7, 1.5.0, 1.3.3, 1.2.7
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Attachments: HBASE-21061-branch-1.v0.patch
>
>
> fix findbugs highlighted issue
> {code}
> Inconsistent synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap; locked 75% of time
> Unsynchronized access at RpcServer.java:75% of time Unsynchronized access at
> RpcServer.java
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
