[ 
https://issues.apache.org/jira/browse/HBASE-21061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598099#comment-16598099
 ] 

Sean Busbey commented on HBASE-21061:
-------------------------------------

javac warning:
{code}
$ cat /tmp/yetus-27066.15542/diff-compile-javac-hbase-server.txt 
[WARNING] 
/testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:[1713,28]
 [InputStreamSlowMultibyteRead] Please also override int read(byte[], int, 
int), otherwise multi-byte reads from this input stream are likely to be slow.
{code}

It's unrelated, just not recognized as a dup because of how many lines the 
method moved due to the patch. shows up above as one fixed and one new:
{code}
$ diff /tmp/yetus-27066.15542/branch-compile-javac-hbase-server.txt 
/tmp/yetus-27066.15542/patch-compile-javac-hbase-server.txt 
2c2
< [WARNING] 
/testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:[1702,26]
 [InputStreamSlowMultibyteRead] Please also override int read(byte[], int, 
int), otherwise multi-byte reads from this input stream are likely to be slow.
---
> [WARNING] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:[1713,28]
>  [InputStreamSlowMultibyteRead] Please also override int read(byte[], int, 
> int), otherwise multi-byte reads from this input stream are likely to be slow.
{code}

> fix synchronization of 
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-21061
>                 URL: https://issues.apache.org/jira/browse/HBASE-21061
>             Project: HBase
>          Issue Type: Sub-task
>          Components: rpc
>    Affects Versions: 1.5.0, 1.3.3, 1.2.7, 1.4.7
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>         Attachments: HBASE-21061-branch-1.v0.patch
>
>
> fix findbugs highlighted issue
> {code}
> Inconsistent synchronization of 
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap; locked 75% of time 
> Unsynchronized access at RpcServer.java:75% of time Unsynchronized access at 
> RpcServer.java
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to