[
https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598196#comment-16598196
]
Hadoop QA commented on HBASE-21129:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m
18s{color} | {color:red} hbase-server in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
34s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
24s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
21s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 24s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 21s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
39s{color} | {color:red} hbase-client: The patch generated 5 new + 421
unchanged - 0 fixed = 426 total (was 421) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
37s{color} | {color:red} hbase-server: The patch generated 1 new + 0 unchanged
- 36 fixed = 1 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
0s{color} | {color:red} patch has 14 errors when building our shaded downstream
artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
27s{color} | {color:red} The patch causes 15 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
58s{color} | {color:red} The patch causes 15 errors with Hadoop v3.0.0. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
5s{color} | {color:red} hbase-client generated 28 new + 0 unchanged - 0 fixed =
28 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
20s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
14s{color} | {color:red} hbase-server in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
4s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 20s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
38s{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 22s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
| | Equals method for org.apache.hadoop.hbase.filter.ColumnCountGetFilter
assumes the argument is of type ColumnCountGetFilter At
ColumnCountGetFilter.java:the argument is of type ColumnCountGetFilter At
ColumnCountGetFilter.java:[line 139] |
| | Equals method for org.apache.hadoop.hbase.filter.ColumnPaginationFilter
assumes the argument is of type ColumnPaginationFilter At
ColumnPaginationFilter.java:the argument is of type ColumnPaginationFilter At
ColumnPaginationFilter.java:[line 237] |
| | Equals method for org.apache.hadoop.hbase.filter.ColumnPrefixFilter
assumes the argument is of type ColumnPrefixFilter At
ColumnPrefixFilter.java:the argument is of type ColumnPrefixFilter At
ColumnPrefixFilter.java:[line 167] |
| | Equals method for org.apache.hadoop.hbase.filter.ColumnRangeFilter
assumes the argument is of type ColumnRangeFilter At
ColumnRangeFilter.java:the argument is of type ColumnRangeFilter At
ColumnRangeFilter.java:[line 246] |
| | Equals method for org.apache.hadoop.hbase.filter.ColumnValueFilter
assumes the argument is of type ColumnValueFilter At
ColumnValueFilter.java:the argument is of type ColumnValueFilter At
ColumnValueFilter.java:[line 245] |
| | Equals method for org.apache.hadoop.hbase.filter.CompareFilter assumes
the argument is of type CompareFilter At CompareFilter.java:the argument is of
type CompareFilter At CompareFilter.java:[line 328] |
| | Equals method for org.apache.hadoop.hbase.filter.DependentColumnFilter
assumes the argument is of type DependentColumnFilter At
DependentColumnFilter.java:the argument is of type DependentColumnFilter At
DependentColumnFilter.java:[line 318] |
| | Equals method for org.apache.hadoop.hbase.filter.FamilyFilter assumes the
argument is of type FamilyFilter At FamilyFilter.java:the argument is of type
FamilyFilter At FamilyFilter.java:[line 152] |
| | Equals method for org.apache.hadoop.hbase.filter.FilterList assumes the
argument is of type FilterList At FilterList.java:the argument is of type
FilterList At FilterList.java:[line 283] |
| | Equals method for org.apache.hadoop.hbase.filter.FirstKeyOnlyFilter
assumes the argument is of type FirstKeyOnlyFilter At
FirstKeyOnlyFilter.java:the argument is of type FirstKeyOnlyFilter At
FirstKeyOnlyFilter.java:[line 133] |
| | Equals method for
org.apache.hadoop.hbase.filter.FirstKeyValueMatchingQualifiersFilter assumes
the argument is of type FirstKeyValueMatchingQualifiersFilter At
FirstKeyValueMatchingQualifiersFilter.java:the argument is of type
FirstKeyValueMatchingQualifiersFilter At
FirstKeyValueMatchingQualifiersFilter.java:[line 140] |
| | Equals method for org.apache.hadoop.hbase.filter.FuzzyRowFilter assumes
the argument is of type FuzzyRowFilter At FuzzyRowFilter.java:the argument is
of type FuzzyRowFilter At FuzzyRowFilter.java:[line 653] |
| | Equals method for org.apache.hadoop.hbase.filter.InclusiveStopFilter
assumes the argument is of type InclusiveStopFilter At
InclusiveStopFilter.java:the argument is of type InclusiveStopFilter At
InclusiveStopFilter.java:[line 137] |
| | Equals method for org.apache.hadoop.hbase.filter.KeyOnlyFilter assumes
the argument is of type KeyOnlyFilter At KeyOnlyFilter.java:the argument is of
type KeyOnlyFilter At KeyOnlyFilter.java:[line 140] |
| | Equals method for org.apache.hadoop.hbase.filter.MultiRowRangeFilter
assumes the argument is of type MultiRowRangeFilter At
MultiRowRangeFilter.java:the argument is of type MultiRowRangeFilter At
MultiRowRangeFilter.java:[line 543] |
| | Equals method for
org.apache.hadoop.hbase.filter.MultipleColumnPrefixFilter assumes the argument
is of type MultipleColumnPrefixFilter At MultipleColumnPrefixFilter.java:the
argument is of type MultipleColumnPrefixFilter At
MultipleColumnPrefixFilter.java:[line 214] |
| | Equals method for org.apache.hadoop.hbase.filter.PageFilter assumes the
argument is of type PageFilter At PageFilter.java:the argument is of type
PageFilter At PageFilter.java:[line 157] |
| | Equals method for org.apache.hadoop.hbase.filter.PrefixFilter assumes the
argument is of type PrefixFilter At PrefixFilter.java:the argument is of type
PrefixFilter At PrefixFilter.java:[line 162] |
| | Equals method for org.apache.hadoop.hbase.filter.QualifierFilter assumes
the argument is of type QualifierFilter At QualifierFilter.java:the argument
is of type QualifierFilter At QualifierFilter.java:[line 149] |
| | Equals method for org.apache.hadoop.hbase.filter.RandomRowFilter assumes
the argument is of type RandomRowFilter At RandomRowFilter.java:the argument
is of type RandomRowFilter At RandomRowFilter.java:[line 161] |
| | Equals method for org.apache.hadoop.hbase.filter.RowFilter assumes the
argument is of type RowFilter At RowFilter.java:the argument is of type
RowFilter At RowFilter.java:[line 166] |
| | org.apache.hadoop.hbase.filter.RowFilter defines equals but not hashCode
At RowFilter.java:hashCode At RowFilter.java:[line 166] |
| | Equals method for
org.apache.hadoop.hbase.filter.SingleColumnValueExcludeFilter assumes the
argument is of type SingleColumnValueExcludeFilter At
SingleColumnValueExcludeFilter.java:the argument is of type
SingleColumnValueExcludeFilter At SingleColumnValueExcludeFilter.java:[line
247] |
| | Equals method for org.apache.hadoop.hbase.filter.SingleColumnValueFilter
assumes the argument is of type SingleColumnValueFilter At
SingleColumnValueFilter.java:the argument is of type SingleColumnValueFilter
At SingleColumnValueFilter.java:[line 467] |
| | Equals method for org.apache.hadoop.hbase.filter.SkipFilter assumes the
argument is of type SkipFilter At SkipFilter.java:the argument is of type
SkipFilter At SkipFilter.java:[line 168] |
| | Equals method for org.apache.hadoop.hbase.filter.TimestampsFilter assumes
the argument is of type TimestampsFilter At TimestampsFilter.java:the argument
is of type TimestampsFilter At TimestampsFilter.java:[line 245] |
| | Equals method for org.apache.hadoop.hbase.filter.ValueFilter assumes the
argument is of type ValueFilter At ValueFilter.java:the argument is of type
ValueFilter At ValueFilter.java:[line 145] |
| | Equals method for org.apache.hadoop.hbase.filter.WhileMatchFilter assumes
the argument is of type WhileMatchFilter At WhileMatchFilter.java:the argument
is of type WhileMatchFilter At WhileMatchFilter.java:[line 170] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21129 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12937744/HBASE-21129.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d0cf93c81b35 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7c1fad4992 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/branch-compile-hbase-server.txt
|
| findbugs | v3.1.0-RC3 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-mvninstall-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-compile-hbase-client.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-compile-hbase-server.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-compile-hbase-client.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-compile-hbase-server.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-shadedjars.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-javac-2.7.4.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-javac-3.0.0.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/new-findbugs-hbase-client.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-findbugs-hbase-server.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-javadoc-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/testReport/ |
| Max. process+thread count | 930 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server hbase-spark U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14259/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Clean up duplicate codes in #equals and #hashCode methods of Filter
> -------------------------------------------------------------------
>
> Key: HBASE-21129
> URL: https://issues.apache.org/jira/browse/HBASE-21129
> Project: HBase
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Minor
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21129.master.001.patch,
> HBASE-21129.master.002.patch
>
>
> It is a follow-up of HBASE-19008, aiming to clean up duplicate codes in
> #equals and #hashCode methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
