[ 
https://issues.apache.org/jira/browse/HBASE-20940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598221#comment-16598221
 ] 

Vishal Khandelwal commented on HBASE-20940:
-------------------------------------------

[~lhofhansl] I think changes done in [^PHOENIX-4839.patch] should mitigate the 
perf risk. preStoreScannerOpen method which makes the call to  hasReference has 
been remove. We may still have this call during preCompact but IMO that should 
be fine.

Also, we were coming to this situation mostly because of HBASE-21047 and once 
it is fixed I hope chances of hitting this would reduce.

 

 

 

> HStore.cansplit should not allow split to happen if it has references
> ---------------------------------------------------------------------
>
>                 Key: HBASE-20940
>                 URL: https://issues.apache.org/jira/browse/HBASE-20940
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.3.2
>            Reporter: Vishal Khandelwal
>            Assignee: Vishal Khandelwal
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 1.3.3, 2.2.0, 2.1.1, 1.4.7, 2.0.3
>
>         Attachments: HBASE-20940-branch-1-addendum.patch, 
> HBASE-20940.branch-1.3.v1.patch, HBASE-20940.branch-1.3.v2.patch, 
> HBASE-20940.branch-1.v1.patch, HBASE-20940.branch-1.v2.patch, 
> HBASE-20940.branch-1.v3.patch, HBASE-20940.branch-1.v5.patch, 
> HBASE-20940.v1.patch, HBASE-20940.v2.patch, HBASE-20940.v3.patch, 
> HBASE-20940.v4.patch, result_HBASE-20940.branch-1.v2.log
>
>
> When split happens and immediately another split happens, it may result into 
> a split of a region who still has references to its parent. More details 
> about scenario can be found here HBASE-20933
> HStore.hasReferences should check from fs.storefile rather than in memory 
> objects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to