[ https://issues.apache.org/jira/browse/HBASE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221192#comment-13221192 ]
jirapos...@reviews.apache.org commented on HBASE-5444: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4149/#review5574 ----------------------------------------------------------- src/main/proto/HMasterRegionProtocol.proto <https://reviews.apache.org/r/4149/#comment12072> Can we doc whats in here better? src/main/proto/HMasterRegionProtocol.proto <https://reviews.apache.org/r/4149/#comment12073> Is this one k/v only? Isn't it possible to pass more than just the one k/v? An actual Map? src/main/proto/HMasterRegionProtocol.proto <https://reviews.apache.org/r/4149/#comment12075> Doesn't exising interface have doc. Could we port that over? - Michael On 2012-03-02 01:30:36, Gregory Chanan wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4149/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-03-02 01:30:36) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. Protobuf work for HMasterRegionInterface. bq. bq. No need to comment on the pom.xml changes: I just copied those from HBASE-5443 (https://reviews.apache.org/r/4054/). bq. bq. bq. This addresses bug HBASE-5444. bq. https://issues.apache.org/jira/browse/HBASE-5444 bq. bq. bq. Diffs bq. ----- bq. bq. pom.xml 0f0aa9a bq. src/main/proto/HMasterRegionProtocol.proto PRE-CREATION bq. src/main/proto/hbase.proto PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/4149/diff bq. bq. bq. Testing bq. ------- bq. bq. mvn -DskipTests package successful and files generated successfully bq. bq. bq. Thanks, bq. bq. Gregory bq. bq. > Add PB-based calls to HMasterRegionInterface > -------------------------------------------- > > Key: HBASE-5444 > URL: https://issues.apache.org/jira/browse/HBASE-5444 > Project: HBase > Issue Type: Sub-task > Components: ipc, master, migration, regionserver > Reporter: Todd Lipcon > Assignee: Gregory Chanan > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira