[ 
https://issues.apache.org/jira/browse/HBASE-21181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611352#comment-16611352
 ] 

Mingliang Liu commented on HBASE-21181:
---------------------------------------

+1 (non-binding)

{{walDir}} and {{walArchiveDir}} dir should be managed together by the same 
file system (FS). Otherwise, the WAL FS will [fail to 
create|https://github.com/apache/hbase/blob/b83613fdce7c5e57766417768b2fa1a13fcb4106/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java#L229]
 a {{walArchiveDir}} which is resolved on root FS. Other than that, this patch 
makes sense for another more obvious reason: we archive the wal log files by 
{{fs.rename()}}.



> Use the same filesystem for wal archive directory and wal directory
> -------------------------------------------------------------------
>
>                 Key: HBASE-21181
>                 URL: https://issues.apache.org/jira/browse/HBASE-21181
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.1.1
>            Reporter: Tak Lon (Stephen) Wu
>            Assignee: Tak Lon (Stephen) Wu
>            Priority: Major
>         Attachments: HBASE-21181.master.001.patch
>
>
> when {{hbase.wal.dir}} is set to any filesystem other than the same 
> filesystem used by rootDir e.g. {{hbase.wal.dir}} set to 
> {{hdfs://something/wal}} and {{hbase.rootdir}} set to {{s3://something}}, 
> before this change, WAL archive directory ({{walArchiveDir}}) cannot be 
> created and failed the WALProcedureStore on HMaster.
> The issue is that WAL archive directory was considered to be collocated with 
> {{hbase.rootdir}} and creates a subdirectory under it. this logic needs to be 
> updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to